From 010569f5f33dbfdae9f64dd1359dfeb04c648c24 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Tue, 10 Jan 2023 16:53:50 -0800 Subject: [PATCH] Remove supports_pic This was dead code and i assumed that was a bug, but the bug was it being there at all https://github.com/bazelbuild/bazel/issues/12439 --- crosstool/cc_toolchain_config.bzl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/crosstool/cc_toolchain_config.bzl b/crosstool/cc_toolchain_config.bzl index 13b7c8e..266e693 100644 --- a/crosstool/cc_toolchain_config.bzl +++ b/crosstool/cc_toolchain_config.bzl @@ -893,8 +893,6 @@ def _impl(ctx): else: apply_simulator_compiler_flags_feature = feature(name = "apply_simulator_compiler_flags") - supports_pic_feature = feature(name = "supports_pic", enabled = True) - fastbuild_feature = feature(name = "fastbuild") no_legacy_features_feature = feature(name = "no_legacy_features") @@ -2722,7 +2720,6 @@ def _impl(ctx): ubsan_feature, default_sanitizer_flags_feature, archive_param_file_feature, - supports_pic_feature, ] elif (ctx.attr.cpu == "darwin_x86_64" or ctx.attr.cpu == "darwin_arm64" or @@ -2805,7 +2802,6 @@ def _impl(ctx): ubsan_feature, default_sanitizer_flags_feature, archive_param_file_feature, - supports_pic_feature, ] else: fail("Unreachable")