Fixes for macOS #177
Merged
Fixes for macOS #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With newer versions of macOS, LLVM and Bazel, a few things have changed and need to be accounted. - Chained fixups is a new feature that generates a warning when dynamic lookup is used for undefined symbols. Bazel's default local toolchain has now removed the dynamic lookups. See bazelbuild/bazel#16413. However, the issue is a little more complex, so we keep it for now and document the ongoing resolution threads. - Bazel 6.0.0 onwards have started using @loader_path; we need to update the wrapper script to handle these options accordingly. - Some basic test fixes for macOS M1 when an LLVM distribution is available, e.g. for LLVM version 15.0.0.
rwooster
pushed a commit
to rwooster/bazel-toolchain
that referenced
this pull request
May 18, 2023
With newer versions of macOS, LLVM and Bazel, a few things have changed and need to be accounted. - Chained fixups is a new feature that generates a warning when dynamic lookup is used for undefined symbols. Bazel's default local toolchain has now removed the dynamic lookups (see bazelbuild/bazel#16413). However, the issue is a little more complex, so we keep it for now and document the ongoing resolution threads between Apple and the community. - Bazel 6.0.0 onwards have started using @loader_path; we need to update the wrapper script to handle these options accordingly. - Some basic test fixes for macOS M1 when an LLVM distribution is available, e.g. for LLVM version 15.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With newer versions of macOS, LLVM and Bazel, a few things have changed and need to be accounted.
ld: warning: -undefined dynamic_lookup may not work with chained fixupsbazelbuild/bazel#16413