Add legacy namespace package test

Author: hartikainen

MODULE.bazel

@@ -213,6 +213,8 @@ use_repo(
     "buildkite_config",
     "implicit_namespace_ns_sub1",
     "implicit_namespace_ns_sub2",
+    "implicit_namespace_legacy",
+    "implicit_namespace_legacy_sub",
     "rules_python_runtime_env_tc_info",
     "somepkg_with_build_files",
     "whl_with_build_files",

python/private/internal_dev_deps.bzl

@@ -67,6 +67,30 @@ def _internal_dev_deps_impl(mctx):
         enable_implicit_namespace_pkgs = False,
     )
 
+    whl_from_dir_repo(
+        name = "implicit_namespace_legacy_whl",
+        root = "//tests/implicit_namespace_packages:testdata/ns-legacy/BUILD.bazel",
+        output = "ns_legacy-1.0-any-none-any.whl",
+    )
+    whl_library(
+        name = "implicit_namespace_legacy",
+        whl_file = "@implicit_namespace_legacy_whl//:ns_legacy-1.0-any-none-any.whl",
+        requirement = "ns-legacy",
+        enable_implicit_namespace_pkgs = False,
+    )
+
+    whl_from_dir_repo(
+        name = "implicit_namespace_legacy_sub_whl",
+        root = "//tests/implicit_namespace_packages:testdata/ns-legacy-sub/BUILD.bazel",
+        output = "ns_legacy_sub-1.0-any-none-any.whl",
+    )
+    whl_library(
+        name = "implicit_namespace_legacy_sub",
+        whl_file = "@implicit_namespace_legacy_sub_whl//:ns_legacy_sub-1.0-any-none-any.whl",
+        requirement = "ns-legacy-sub",
+        enable_implicit_namespace_pkgs = False,
+    )
+
 internal_dev_deps = module_extension(
     implementation = _internal_dev_deps_impl,
     doc = "This extension creates internal rules_python dev dependencies.",

tests/implicit_namespace_packages/BUILD.bazel

@@ -8,5 +8,7 @@ py_test(
     deps = [
         "@implicit_namespace_ns_sub1//:pkg",
         "@implicit_namespace_ns_sub2//:pkg",
+        "@implicit_namespace_legacy//:pkg",
+        "@implicit_namespace_legacy_sub//:pkg",
     ],
 )

tests/implicit_namespace_packages/namespace_packages_test.py

@@ -20,5 +20,24 @@ def test_both_importable(self):
         )
 
 
+    def test_legacy_packages_importable(self):
+        import legacy_main
+        import legacy_main.subpkg1
+        import legacy_main.subpkg1.subpkgmod
+
+        import legacy_side
+        import legacy_side.subpkg1
+        import legacy_side.subpkg1.subpkgmod
+
+        self.assertEqual("legacy_main.subpkg1", legacy_main.subpkg1.expected_name)
+        self.assertEqual(
+            "legacy_main.subpkg1.subpkgmod", legacy_main.subpkg1.subpkgmod.expected_name
+        )
+        self.assertEqual("legacy_side.subpkg1", legacy_side.subpkg1.expected_name)
+        self.assertEqual(
+            "legacy_side.subpkg1.subpkgmod", legacy_side.subpkg1.subpkgmod.expected_name
+        )
+
+
 if __name__ == "__main__":
     unittest.main()

tests/implicit_namespace_packages/testdata/ns-legacy-sub/ns_legacy_sub-1.0.dist-info/METADATA

@@ -0,0 +1 @@
+Wheel-Version: 1.0

tests/implicit_namespace_packages/testdata/ns-legacy-sub/ns_legacy_sub-1.0.dist-info/RECORD

@@ -0,0 +1,13 @@
+# TODO(hartikainen): Check this.
+
+
+
+
+
+
+
+
+# # NOTE: This is the `pkgutil`-style, way to extend namespace packages.
+# # For more information, see:
+# # https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages
+# __path__ = __import__('pkgutil').extend_path(__path__, __name__)

tests/implicit_namespace_packages/testdata/ns-legacy-sub/ns_legacy_sub-1.0.dist-info/WHEEL

@@ -0,0 +1 @@
+expected_name = "legacy_sub.subpkg1"

tests/implicit_namespace_packages/testdata/ns-legacy-sub/ns_legacy_sub/__init__.py

@@ -0,0 +1 @@
+expected_name = "legacy_sub.subpkg1.subpkgmod"