Skip to content

Commit 5caf332

Browse files
author
Alex Eagle
committed
chore: tsc_wrapped worker mode needs require patches
1 parent 9a5a5c1 commit 5caf332

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

.bazelci/presubmit.yml

-2
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,6 @@ tasks:
447447
# TODO(gregmagolan): figure out how to install missing shared libs
448448
# Without this filter the @cypress external repository will be built and that build will fail due to missing shared libs.
449449
- "--build_tag_filters=-cypress,-pkg_npm.pack"
450-
- "--define=NODE_DEBUG=module"
451-
- "--define=VERBOSE_LOGS=1"
452450
test_flags:
453451
# TODO(gregmagolan): figure out how to install missing shared libs
454452
- "--test_arg=-cypress"

examples/angular/tools/BUILD.bazel

+2
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ nodejs_binary(
1111
"@npm//@bazel/typescript",
1212
],
1313
entry_point = "@npm//:node_modules/@bazel/typescript/internal/tsc_wrapped/tsc_wrapped.js",
14+
# TODO: turn on --worker_sandboxing and remove this flag to see failure to load the plugin
15+
templated_args = ["--bazel_patch_module_resolver"],
1416
visibility = ["//:__subpackages__"],
1517
)

third_party/github.com/bazelbuild/rules_typescript/internal/BUILD.bazel

+3
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ nodejs_binary(
8383
],
8484
entry_point = ":tsc_wrapped/tsc_wrapped.js",
8585
visibility = ["//visibility:public"],
86+
# With RBE or --worker_sandboxing you'll see that worker doesn't run_node
87+
# so it doesn't have the linker
88+
templated_args = ["--bazel_patch_module_resolver"],
8689
)
8790

8891
ts_library(

0 commit comments

Comments
 (0)