You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The dependency definition for grpc-core is missing the exclusion of grpc-util. This exclusion is important to keep for downstream consumers.
We used to work around this because exclusions were stored in the old maven_install.json format (4.X). However we want to now upgrade to 6.1 with the newer lockfile format, but it does not include exclusions information anymore.
Using the examples in the documentation, consider the following setup:
If we build the generated pom for
exported_lib
, we get the following output:The dependency definition for
grpc-core
is missing the exclusion ofgrpc-util
. This exclusion is important to keep for downstream consumers.We used to work around this because exclusions were stored in the old
maven_install.json
format (4.X). However we want to now upgrade to 6.1 with the newer lockfile format, but it does not include exclusions information anymore.I think this could be done by extending
MavenInfo
and https://github.com/bazelbuild/rules_jvm_external/blob/master/private/rules/has_maven_deps.bzl to pick up exclusions, then wiring it into the pom.xml. Maybejvm_import
should store exclusions in an attribute, or it should be tag based?The text was updated successfully, but these errors were encountered: