From a4e210ac62ae2cee9d0ba8ad62a1ae88425f851a Mon Sep 17 00:00:00 2001 From: Yoshi Yamaguchi <145104+ymotongpoo@users.noreply.github.com> Date: Sun, 26 Apr 2020 23:41:03 +0900 Subject: [PATCH 1/2] Fix small typo and obsolete expressions. * Fix typo in default value in `go_download_sdk` * Change "Skylark" to "Starlark" to meet current name --- go/toolchains.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/go/toolchains.rst b/go/toolchains.rst index d844986ca2..5e65e09740 100644 --- a/go/toolchains.rst +++ b/go/toolchains.rst @@ -149,7 +149,7 @@ Registering a custom SDK ~~~~~~~~~~~~~~~~~~~~~~~~ If you download the SDK through another repository rule, you can configure -it with ``go_wrap_sdk``. It must still be named ``go_sdk``, but this is a +it with ``go_wrap_sdk``. It must still be named ``go_sdk``, but this is a temporary limitation that will be removed in the future. .. code:: bzl @@ -268,7 +268,7 @@ This downloads a Go SDK for use in toolchains. | supports. Go versions that rules_go doesn't support may not be specified, | | since the download SHA-256 sums are not known. | +--------------------------------+-----------------------------+---------------------------------------------+ -| :param:`urls` | :type:`string_list` | :value:`[https://dl.google.com/go/{}` | +| :param:`urls` | :type:`string_list` | :value:`[https://dl.google.com/go/{}]` | +--------------------------------+-----------------------------+---------------------------------------------+ | A list of mirror urls to the binary distribution of a Go SDK. These must contain the `{}` | | used to substitute the sdk filename being fetched (using `.format`. | @@ -467,7 +467,7 @@ The context object ~~~~~~~~~~~~~~~~~~ ``GoContext`` is never returned by a rule, instead you build one using -``go_context(ctx)`` in the top of any custom skylark rule that wants to interact +``go_context(ctx)`` in the top of any custom starlark rule that wants to interact with the go rules. It provides all the information needed to create go actions, and create or interact with the other go providers. From 39c8987bb5953170d41c53aa95f13d523946131b Mon Sep 17 00:00:00 2001 From: Yoshi Yamaguchi <145104+ymotongpoo@users.noreply.github.com> Date: Tue, 28 Apr 2020 07:35:17 +0900 Subject: [PATCH 2/2] Remove extra trailing space to render the table properly. --- go/toolchains.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go/toolchains.rst b/go/toolchains.rst index 5e65e09740..2c7c6d5784 100644 --- a/go/toolchains.rst +++ b/go/toolchains.rst @@ -268,7 +268,7 @@ This downloads a Go SDK for use in toolchains. | supports. Go versions that rules_go doesn't support may not be specified, | | since the download SHA-256 sums are not known. | +--------------------------------+-----------------------------+---------------------------------------------+ -| :param:`urls` | :type:`string_list` | :value:`[https://dl.google.com/go/{}]` | +| :param:`urls` | :type:`string_list` | :value:`[https://dl.google.com/go/{}]` | +--------------------------------+-----------------------------+---------------------------------------------+ | A list of mirror urls to the binary distribution of a Go SDK. These must contain the `{}` | | used to substitute the sdk filename being fetched (using `.format`. |