Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkerboard masking in RealNVP #47

Open
Donglin-Wang2 opened this issue Aug 4, 2021 · 2 comments
Open

Checkerboard masking in RealNVP #47

Donglin-Wang2 opened this issue Aug 4, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Donglin-Wang2
Copy link
Contributor

Hi,

Since the CouplingTransform class in nflows.transforms.coupling module only supports a 1-d mask that splits data along the channel dimension, I am wondering how I would go about implementing the alternating checkerboard mask in the RealNVP paper? Should I used the MaskedAffineAutoregressiveTransform in the nflows.transforms.autoregressive instead? Or are there some other methods or classes that I am not aware of?

Also, thank you so much for providing such a clean implementation of flow models in PyTorch!

Sincerely,
Donglin Wang

@arturbekasov
Copy link
Contributor

arturbekasov commented Sep 11, 2022

Hey Donglin. Nope, unfortunately the checkerboard masking isn't implemented. I'll keep this issue around in case you (or someone else) want to implement it. Cheers, Artur

@arturbekasov arturbekasov changed the title Question regarding checkerboard mask implementation in RealNVP Checkerboard masking in RealNVP Sep 11, 2022
@arturbekasov
Copy link
Contributor

We do have a RealNVP implementation with 1D checkerboard masking, though: https://github.com/bayesiains/nflows/blob/master/nflows/flows/realnvp.py#L17

@arturbekasov arturbekasov added the enhancement New feature or request label Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants