Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'#' character within config value [JIRA: RIAK-2547] #167

Open
dergraf opened this issue Sep 16, 2014 · 4 comments
Open

'#' character within config value [JIRA: RIAK-2547] #167

dergraf opened this issue Sep 16, 2014 · 4 comments

Comments

@dergraf
Copy link

dergraf commented Sep 16, 2014

According to the 'conf_parse.peg' a comment is specified as any line that begins with a '#' sign (leading whitespace is allowed). However a '#' character appearing within a value (no leading whitespace) is treated as a comment as well. Is this intentional?

1> conf_parse:parse("my.config.val = test/#").
[{["my","config","val"],"test/"}]

PS: my use case is the configuration of a MQTT topic pattern which uses '#' as a wildcard character.

@seancribbs
Copy link
Contributor

Yes, that is intentional, so that trailing comments are allowed. We could potentially tweak the grammar such that you could quote the RHS or escape the #.

@dergraf
Copy link
Author

dergraf commented Sep 17, 2014

Hi Sean,
escaping # would work for me.

@RJ
Copy link

RJ commented May 9, 2016

I would also like escaping \# or "#quoting", for specifying IRC channel names and rabbitmq paths.

@Basho-JIRA Basho-JIRA changed the title '#' character within config value '#' character within config value [JIRA: RIAK-2547] May 9, 2016
@bwegh
Copy link

bwegh commented Dec 6, 2016

I also need the support for # in the config value.
escpaping \# or "quo#ting" are both okay with me. within quoting then again with support for escpaing of " like "quo#\"ting".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants