Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--cpu-count is a Windows-only option #49

Open
marckohlbrugge opened this issue Jan 26, 2024 · 1 comment
Open

--cpu-count is a Windows-only option #49

marckohlbrugge opened this issue Jan 26, 2024 · 1 comment

Comments

@marckohlbrugge
Copy link

marckohlbrugge commented Jan 26, 2024

Kamal's docs mention a --cpu-count option here:

job:
hosts:
- 192.168.0.3
- 192.168.0.4
cmd: bin/jobs
options:
cap-add: true
cpu-count: 4
```
That'll start the job containers with `docker run ... --cap-add --cpu-count 4 ...`.

It took me a while to figure out why it didn't work for me. Turns out it's a Windows-only option:

--cpu-count CPU count (Windows only)

Source: https://docs.docker.com/engine/reference/commandline/container_run/#options

I think we should suggest the more universal --cpus option instead:

-cpus [API 1.25+](https://docker-docs.uclv.cu/engine/api/v1.25/) Number of CPUs


I'm new to Docker. I could be wrong. I'm also not sure if Kamal uses API 1.25+.

@dhh
Copy link
Member

dhh commented Sep 28, 2024

Yes, please do add a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants