Skip to content

Commit 0357324

Browse files
committed
A bit of refactoring - still not happy with it.
1 parent fec95ed commit 0357324

File tree

1 file changed

+20
-4
lines changed

1 file changed

+20
-4
lines changed

lib/ssl_requirement.rb

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,30 @@ def determine_host_and_port(request, ssl)
144144
request_port = request.port
145145

146146
if ssl
147-
port = (request_port == non_ssl_port) ? ssl_port : (request_port || ssl_port)
148-
"#{(ssl_host || request_host)}#{determine_port_string(port)}"
147+
"#{ssl_host || request_host}#{determine_ssl_port_string request.port}"
149148
else
150-
port = (request_port == ssl_port) ? non_ssl_port : (request_port || non_ssl_port)
151-
"#{(non_ssl_host || request_host)}#{determine_port_string(port)}"
149+
"#{non_ssl_host || request_host}#{determine_non_ssl_port_string request.port}"
152150
end
153151
end
154152

153+
def determine_ssl_port_string(request_port)
154+
if request_port == non_ssl_port
155+
port = ssl_port
156+
else
157+
port = request_port || ssl_port
158+
end
159+
determine_port_string port
160+
end
161+
162+
def determine_non_ssl_port_string(request_port)
163+
if request_port == ssl_port
164+
port = non_ssl_port
165+
else
166+
port = request_port || non_ssl_port
167+
end
168+
determine_port_string port
169+
end
170+
155171
def self.determine_host(host)
156172
if host.is_a?(Proc) || host.respond_to?(:call)
157173
host.call

0 commit comments

Comments
 (0)