Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance RPGLE syntax coloring #127

Conversation

chrjorgensen
Copy link
Collaborator

This PR will enhance the syntax coloring for RPGLE files:

  • BIF's will be marked as support functions
  • Compiler directives will be marked as keyword controls
  • Operators will be marked as such
  • Identifiers will be marked as variables

This PR was created since most syntax elements for RPGLE were keyword.other and produced a "dull" view of the code, in contrast to other languages in VS Code. With this PR more colors are used to identify elements in RPGLE code.

The RPGLE samples has also been updated with more syntax examples.

I have tested this but would like your 馃憖 on it as well.

@chrjorgensen
Copy link
Collaborator Author

@barrettotte If you think it is a good idea, I would be happy to step in as maintainer of this project next to you. I'm also maintainer for Code for IBM i and these two extensions are closely related.

This could be beneficial to all of us. Maybe @worksofliam would be interested as well - although I know he is very busy working for IBM and simultaneously on Code for IBM i and related extensions.

WDYT?

@chrjorgensen chrjorgensen changed the title Enhance rpgle syntax coloring Enhance RPGLE syntax coloring Apr 13, 2023
@barrettotte
Copy link
Owner

barrettotte commented Apr 13, 2023

Awesome, colors and tweaks look good to me.

Haha wow yeah I should have added you and @worksofliam as contributors years ago. I apologize for waiting so long to do that; As of now, you both are contributors.

Unfortunately, my IBM i days may be over (outside of trying to restore an old AS/400). But, I can still be available for misc bug fixes if needed.

Thanks again for all the work you guys do.

@barrettotte barrettotte merged commit 28d8f23 into barrettotte:master Apr 13, 2023
@chrjorgensen
Copy link
Collaborator Author

@barrettotte Thank you for your trust and making me and @worksofliam contributors to this great extension.
And thank you for all your work so far - without you we would never have had this, and the IBM i community is so grateful!

Hopefully you will still be able to participate - your regexp knowledge is far superior to mine. If you need IBM i access, you can create an account on the free PUB400 IBM i.

Once again, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants