Skip to content

Commit 5898c8e

Browse files
alfredhsreimers
authored andcommitted
rtp: remove rtcp_psfb_sli_encode() (unused)
SLI is not used in our stack. Also contributes to increased code coverage.
1 parent 70f1123 commit 5898c8e

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

src/rtp/fb.c

-18
Original file line numberDiff line numberDiff line change
@@ -48,24 +48,6 @@ int rtcp_rtpfb_gnack_encode(struct mbuf *mb, uint16_t pid, uint16_t blp)
4848
}
4949

5050

51-
/**
52-
* Encode an RTCP Slice Loss Indication (SLI) message
53-
*
54-
* @param mb Buffer to encode into
55-
* @param first Macroblock (MB) address of the first lost macroblock
56-
* @param number Number of lost macroblocks
57-
* @param picid Picture ID
58-
*
59-
* @return 0 for success, otherwise errorcode
60-
*/
61-
int rtcp_psfb_sli_encode(struct mbuf *mb, uint16_t first, uint16_t number,
62-
uint8_t picid)
63-
{
64-
const uint32_t v = first<<19 | number<<6 | picid;
65-
return mbuf_write_u32(mb, htonl(v));
66-
}
67-
68-
6951
/* Decode functions */
7052

7153

src/rtp/rtcp.h

-2
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ int rtcp_make_sdes_cname(const struct rtp_sock *rs, struct mbuf *mb);
5353

5454
/* RTCP Feedback */
5555
int rtcp_rtpfb_gnack_encode(struct mbuf *mb, uint16_t pid, uint16_t blp);
56-
int rtcp_psfb_sli_encode(struct mbuf *mb, uint16_t first, uint16_t number,
57-
uint8_t picid);
5856
int rtcp_rtpfb_twcc_decode(struct mbuf *mb, struct twcc *msg, int n);
5957
int rtcp_rtpfb_decode(struct mbuf *mb, struct rtcp_msg *msg);
6058
int rtcp_psfb_decode(struct mbuf *mb, struct rtcp_msg *msg);

0 commit comments

Comments
 (0)