Skip to content

Commit 198e657

Browse files
committed
test/rtcp: fix OOM tests
1 parent 6493f44 commit 198e657

File tree

1 file changed

+20
-9
lines changed

1 file changed

+20
-9
lines changed

test/rtcp.c

+20-9
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ static int test_loss(const uint16_t *seqv, size_t seqc,
146146
if (err) {
147147
if (err == ENOENT)
148148
err = ENOMEM;
149-
goto out;
149+
TEST_ERR(err);
150150
}
151151

152152
/* in OOM-test, detect if member/sender was not allocated */
@@ -155,9 +155,12 @@ static int test_loss(const uint16_t *seqv, size_t seqc,
155155
stats.rx.jit == 0) {
156156

157157
err = ENOMEM;
158-
goto out;
158+
TEST_ERR(err);
159159
}
160160

161+
if (test_mode == TEST_MEMORY)
162+
goto out;
163+
161164
/* verify expected packets sent and packet loss */
162165
TEST_EQUALS(seqc, stats.rx.sent);
163166
TEST_EQUALS(exp_lost, stats.rx.lost);
@@ -181,14 +184,22 @@ int test_rtcp_packetloss(void)
181184
static const uint16_t seqv7[] = {1,2,8,9,10};
182185
int err = 0;
183186

184-
err |= test_loss(seqv1, RE_ARRAY_SIZE(seqv1), 0);
185-
err |= test_loss(seqv2, RE_ARRAY_SIZE(seqv2), 0);
186-
err |= test_loss(seqv3, RE_ARRAY_SIZE(seqv3), 0);
187-
err |= test_loss(seqv4, RE_ARRAY_SIZE(seqv4), 1);
188-
err |= test_loss(seqv5, RE_ARRAY_SIZE(seqv5), 2);
189-
err |= test_loss(seqv6, RE_ARRAY_SIZE(seqv6), 1);
190-
err |= test_loss(seqv7, RE_ARRAY_SIZE(seqv7), 5);
187+
err = test_loss(seqv1, RE_ARRAY_SIZE(seqv1), 0);
188+
TEST_ERR(err);
189+
err = test_loss(seqv2, RE_ARRAY_SIZE(seqv2), 0);
190+
TEST_ERR(err);
191+
err = test_loss(seqv3, RE_ARRAY_SIZE(seqv3), 0);
192+
TEST_ERR(err);
193+
err = test_loss(seqv4, RE_ARRAY_SIZE(seqv4), 1);
194+
TEST_ERR(err);
195+
err = test_loss(seqv5, RE_ARRAY_SIZE(seqv5), 2);
196+
TEST_ERR(err);
197+
err = test_loss(seqv6, RE_ARRAY_SIZE(seqv6), 1);
198+
TEST_ERR(err);
199+
err = test_loss(seqv7, RE_ARRAY_SIZE(seqv7), 5);
200+
TEST_ERR(err);
191201

202+
out:
192203
return err;
193204
}
194205

0 commit comments

Comments
 (0)