Skip to content

"NoPrintConversion" functional option #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2021
Merged

"NoPrintConversion" functional option #24

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf5e346
Function to add additional argument
Kjeldgaard Mar 22, 2021
9c6c368
Added comments
Kjeldgaard Mar 23, 2021
64f9cc1
Dedicated 'No Print Conversion' function
Kjeldgaard Mar 28, 2021
8e48e57
Fix comment according to godoc
Kjeldgaard Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion exiftool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,4 +184,14 @@ func Charset(charset string) func(*Exiftool) error {
e.extraInitArgs = append(e.extraInitArgs, "-charset", charset)
return nil
}
}
}

// Function to use 'No print conversion' mode, see https://exiftool.org/exiftool_pod.html.
Copy link
Owner

@barasher barasher Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation does not fit godoc specifications. The comment should start with the name fonction.
https://blog.golang.org/godoc

// Sample :
// e, err := NewExiftool(NoPrintConversion())
func NoPrintConversion() func(*Exiftool) error {
return func(e *Exiftool) error {
e.extraInitArgs = append(e.extraInitArgs, "-n")
return nil
}
}
21 changes: 20 additions & 1 deletion exiftool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,4 +233,23 @@ func TestNewExifTool_WithCharset(t *testing.T) {
metas := e.ExtractMetadata("./testdata/20190404_131804.jpg")
assert.Equal(t, 1, len(metas))
assert.Nil(t, metas[0].Err)
}
}

func TestNoPrintConversion(t *testing.T) {
e, err := NewExiftool(NoPrintConversion())
assert.Nil(t, err)
defer e.Close()

metas := e.ExtractMetadata("./testdata/20190404_131804.jpg")
assert.Equal(t, 1, len(metas))
assert.Nil(t, metas[0].Err)

for _, meta := range metas {
if meta.Err != nil {
continue
}
expProgram, err := meta.GetInt("ExposureProgram")
assert.Nil(t, err)
assert.Equal(t, int64(2), expProgram)
}
}