Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect target features #69

Closed
epage opened this issue Feb 3, 2022 · 3 comments
Closed

Detect target features #69

epage opened this issue Feb 3, 2022 · 3 comments

Comments

@epage
Copy link
Contributor

epage commented Feb 3, 2022

In clap, we have clap-rs/clap#1363. I'm tempted to close this out by pointing to shadow. One thing mentioned in that issue but that I'm not seeing in shadow is checking target_feature support (simd flags).
@epage epage mentioned this issue Feb 3, 2022
Closed
@baoyachi
Copy link
Owner

baoyachi commented Feb 22, 2022 •
edited
Loading

Reference link:clap-rs/clap#2840 (comment)

It may be similar to this issue. #53

Do you have any good suggestions. @epage

@epage
Copy link
Contributor Author

epage commented Feb 22, 2022

One idea I have is to create a non-exhaustive enum that either has an as_str or derefs to str that has the string version of the enum (which Display wraps). Then its just a matter of code-genning that similarly to the code in the clap issue.

I can take a crack at this tomorrow if you want.

@baoyachi
Copy link
Owner

baoyachi commented Feb 22, 2022 •
edited
Loading

Yeah，I look forward to your pr. @epage

@epage epage mentioned this issue Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @baoyachi