Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated code not compatible with older clippy versions. #143

Closed
sholderbach opened this issue Sep 26, 2023 · 2 comments
Closed

Generated code not compatible with older clippy versions. #143

sholderbach opened this issue Sep 26, 2023 · 2 comments

Comments

@sholderbach
Copy link

The fix for #141 introduces a problem for folks using an older rust toolchain. Clippy will complain about the unknown lint:

error: unknown lint: `clippy::needless_raw_string_hashes`
Error:   --> /home/runner/work/nushell/nushell/target/debug/build/nu-cmd-lang-05d8af32cd96fda8/out/shadow.rs:12:9
   |
12 | #[allow(clippy::needless_raw_string_hashes)]
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D unknown-lints` implied by `-D warnings`

https://github.com/nushell/nushell/actions/runs/6293295044/job/17083630612?pr=10495

Using 1.70.0 in the rust-toolchain.toml: https://github.com/nushell/nushell/blob/d2f513da36fe3e8b2b60584e28deaa2c4253f666/rust-toolchain.toml#L19

Maybe this can be suppressed by allowing unknown-lints for the file?

@baoyachi
Copy link
Owner

baoyachi commented Oct 7, 2023

@sholderbach new version published, please use:

shadow-rs = "0.24.1"

@baoyachi baoyachi closed this as completed Oct 7, 2023
@sholderbach
Copy link
Author

Awesome! Thanks, good call with the general allow().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants