Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with *-comma-after-newline rules #7

Open
davidwarrington opened this issue Sep 29, 2022 · 2 comments
Open

Issue with *-comma-after-newline rules #7

davidwarrington opened this issue Sep 29, 2022 · 2 comments

Comments

@davidwarrington
Copy link
Contributor

transition:
  background-color 0.3s ease,
  backdrop-filter 0.3s ease,
  color 0.3s ease;

The above works fine locally, but upon saving the pre-commit hook updates the rule to be single line and I get errors about the following rules: declaration-colon-newline-after and value-list-comma-newline-after.

I'm unsure if this is a Prettier vs Stylelint conflict, an issue in Stylelint itself or something else but figured it was best I share here

@dan-gamble
Copy link
Contributor

What you have there is my preferred way of it working. Do you know which one of the rules it's crying about?

@davidwarrington
Copy link
Contributor Author

Screen.Recording.2022-09-30.at.12.40.11.mov

It's both rules mentioned above. If you watch this video, you'll see the pre-commit hook attempts to format it in a manner that Stylelint doesn't agree with. I'm guessing it must actually be prettier-standard causing this conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants