-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffold broken as soon as it is run #35
Comments
+1 |
Yup, I got the same. |
@digijin @Utsav2 @callummr I am not able to reproduce, but wonder if there is a collision between any .babelrc files? Here is where the react-display-name plugin is added in a .babelrc file included in the project: https://github.com/banderson/generator-redux/blob/master/generators/app/templates/_babelrc Do you have a .babelrc in your home directory that may be conflicting? |
Oh, and on second read of the error message, this might be a babel issue in that the plugins of the same name are "colliding". I'll investigate. |
This appears to be happening elsewhere: |
…vert to babel-plugin-react-transform 1.x (2.x is for Babel 6). Fix react-display-name plugin order by making react-transform run after. Fixes banderson#35.
Has this fix been released? Because I've just done clean install of the generator and am still exeriencing this exact issue. Looking at the .babelrc in master and the one placed in the project by the generator differ by what seems to be the issue. I'm going to copy the .babelrc in master into my project and give it a go. |
Same here! |
If anyone finds a fix or work around please post it here thanks. |
@martinffx you are correct, it has not been released yet. The fix is simple, apply the .babelrc change as you said and then ensure you have babel-plugin-react-transform@^1.0.0 - the 2.x branch is meant for Babel 6.x, which this generator has not been updated to use yet (though there is a good PR out there for it). |
@kaylanm thanks, I managed to manually edit the generated code into a working state. Would be nice to fix this generator though. What needs to happen to get this PR merged? |
Hey everyone, I missed this yesterday because it was marked as closed. I released a new version yesterday that includes the babel6 upgrades and a few bug fixes. I hope that this is all set now, so please let me know if you see anything like this after using |
Tried on 5.0.0, 4.2.1, 4.0.0, 0.12.7 and all got the same error.
Installs fine, when I run npm start I get the following error that appears to come out of webpack:
The text was updated successfully, but these errors were encountered: