Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiler): improve timings accuracy #84

Merged
merged 10 commits into from
Apr 7, 2023
Merged

fix(profiler): improve timings accuracy #84

merged 10 commits into from
Apr 7, 2023

Conversation

Almouro
Copy link
Member

@Almouro Almouro commented Mar 31, 2023

No description provided.

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for flashlight-docs canceled.

Name Link
🔨 Latest commit 3e635bb
🔍 Latest deploy log https://app.netlify.com/sites/flashlight-docs/deploys/642ae5721f73930008e74d31

@Almouro Almouro force-pushed the perf/cpp branch 5 times, most recently from 8602559 to 4fb8cba Compare April 3, 2023 08:08
By getting the pid on C++ side, we should get better accuracy on measures on startup and ensure we don't miss the first couple 100ms
BREAKING CHANGE: if using a custom script, pollPerformanceMeasures will now take { onMeasure: (Measure) => void }
as second parameter
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@bamlab bamlab deleted a comment from flashlight-bot Apr 3, 2023
@Almouro Almouro changed the title improve timings accuracy fix(profiler): improve timings accuracy Apr 7, 2023
@Almouro Almouro marked this pull request as ready for review April 7, 2023 08:31
Copy link
Contributor

@EliottG-Bam EliottG-Bam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Almouro Almouro merged commit 1908689 into main Apr 7, 2023
@Almouro Almouro deleted the perf/cpp branch April 7, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants