Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cpu usage per thread ios #150

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Feat/cpu usage per thread ios #150

merged 4 commits into from
Sep 12, 2023

Conversation

GuillaumeEgret
Copy link
Contributor

@GuillaumeEgret GuillaumeEgret commented Aug 24, 2023

Add details about the cpu usage per thread.

Tests:

  • Edit the file packages/ios-poc/src/writeReport.ts to put TIME_INTERVAL to 10 so that the report will be the same as the .trace created by xcode.
  • Launch : yarn workspace flashlight-ios-poc flashlight-ios-poc ios-test --appId org.reactjs.native.example.fakeStore --simulatorId 1C1F5B46-1BEB-4F91-9C95-C5196062E388 --testCommand 'maestro test ./test.yaml' --resultsFilePath 'result.json' and then node packages/web-reporter/dist/openReport.js report ./packages/ios-poc/result.json and compare the result with the .trace that is created.
  • Launch the same first command but with a different output and then node packages/web-reporter/dist/openReport.js report ./packages/ios-poc/result.json <theOtherOutput> to compare reports.
  • Launch node packages/web-reporter/dist/openReport.js report ./packages/ios-poc/result.json <theOtherOutput> -s 500 -d 1000 to ensure that the conditional check removed was indeed useless.
  • Reset TIME_INTERVAL to 500

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for flashlight-docs canceled.

Name Link
🔨 Latest commit 2fd3fec
🔍 Latest deploy log https://app.netlify.com/sites/flashlight-docs/deploys/64e72f8afbe3a8000820ce05

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Flashlight iOS Report 🔦

@flashlight-bot
Copy link
Contributor

Flashlight Automated Report 🔦

@flashlight-bot
Copy link
Contributor

Flashlight Automated Report 🔦

@GuillaumeEgret GuillaumeEgret marked this pull request as ready for review August 24, 2023 12:36
@Almouro Almouro merged commit ef2636c into main Sep 12, 2023
8 checks passed
@Almouro Almouro deleted the feat/cpu-usage-per-thread-ios branch September 12, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants