fix: put the color class name on the icon and not the container #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for flashlight-docs canceled.
|
Flashlight Automated Report 🔦 |
niebo26
approved these changes
Jun 1, 2023
mbezard
force-pushed
the
fix/more-icon-color-should-be-white
branch
from
5beaf32
to
ebd5f71
Compare
Flashlight Automated Report 🔦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't why but it seems that the classnames from MUI was overriding the classname from tailwind on the parent. But when putting the tailwind classname on the icon itself it's not overridden 🙃
So, to remember : the dev should be always putting the
fill-color-00orstroke-color-00on the svg itself (as low as possible)I still don't know why it was working here but not in flashlight-cloud