[Question]: Service and Object have the same TypeTag

[Shadow-Devil]

Description

I don't know if this is a bug or intended, but it seems quite strange that both Object and Service have the same TypeTag. I think it was forgotten to add the +1 to the definition of the service tag.

Relevant code:

ballerina-lang/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/util/TypeTags.java

Lines 60 to 62 in 74c7367

	public static final int OBJECT = FINITE + 1;
	public static final int SERVICE = OBJECT;
	public static final int BYTE_ARRAY = OBJECT + 1;

Steps to Reproduce

No response

Affected Version(s)

No response

OS, DB, other environment details and versions

No response

Related area

-> Compilation

Related issue(s) (optional)

No response

Suggested label(s) (optional)

No response

Suggested assignee(s) (optional)

No response

[MaryamZi]

Previously (pre-Swan Lake) objects and services used to be two separate things. However, with the current service design, services are just another kind of object, so the two being the same is intentional.

We could probably get rid of the service tag altogether though.

[Shadow-Devil]

Thank you for clarifying it. I also added this change to remove the Service TypeTag in one of my PRs where I found it. (#43035)
Commit: df7f0e7