Fix dependently-typed functions with type reference union member types #43017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryamZi
added
the
Team/CompilerFE
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #43017 +/- ##
============================================
- Coverage 77.68% 77.68% -0.01%
+ Complexity 51481 51480 -1
============================================
Files 2933 2933
Lines 204239 204244 +5
Branches 26720 26721 +1
============================================
+ Hits 158666 158667 +1
- Misses 36948 36951 +3
- Partials 8625 8626 +1 ☔ View full report in Codecov by Sentry. |
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/util/Unifier.java
Outdated
Show resolved
Hide resolved
...t-test/src/test/resources/test-src/javainterop/dependently_typed_functions_test_negative.bal
Show resolved
Hide resolved
SasinduDilshara
approved these changes
Jul 3, 2024
| @@ -986,7 +986,8 @@ private BType getMatchingTypeForInferrableType(BType originalType, BType expType | |||
|
|
|||
| for (BType inferableType : inferableTypes) { | |||
| for (BType expectedType : expectedTypes) { | |||
| if (Types.getImpliedType(inferableType).tag == Types.getImpliedType(expectedType).tag) { | |||
| expectedType = Types.getImpliedType(expectedType); | |||
| if (Types.getImpliedType(inferableType).tag == expectedType.tag) { | |||
There was a problem hiding this comment.
Is this correct? When creating the inferableTypes and expectedTypes lists, don't we need to add the original types(by doing the getImpliedType when creating the lists)?
There was a problem hiding this comment.
I was considering the same. But we seem to have worked with implied types even in the non-union case, so decided to do the same in the union case also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title.
Fixes #43012
Check List