Skipper detects incorrect sizes in posted files

[NAlexandrov]

Sails version: 0.12.6
Node version: 6.7.0
NPM version: 3.10.3
Operating system: macOS 10.12

---

Why Skipper detects incorrect file size? I created a new Sails app and made next changes:

config/routes.js

'post /upload': 'UploadController.upload',

config/http.js

bodyParser: require('skipper')({
  strict: true,
}),

api/controllers/UploadController.js

var fs = require('fs');

module.exports.upload = function upload(req, res) {
  req.file('files').upload({
    dirname: __dirname,
    maxBytes: 100 * 1024 * 1024,
  }, function (err, files) {
    files.forEach(function (file) {
      // Correct size in stat.size
      var stat = fs.statSync(file.fd);

      // But incorrect size in file.size
      console.log(file.filename, file.size, stat.size);
    });

    res.ok('ok');
  });
};

request.js for post request:

var fs = require('fs');
var request = require('request');

var data = {
    files: [{
        value: fs.createReadStream('message.eml'),
        options: {
            filename: 'message.eml',
            contentType: 'message/rfc822'
        }
    }, {
        value: fs.createReadStream('attachment.gif'),
        options: {
            filename: 'attachment.gif',
            contentType: 'image/gif'
        }
    }, {
        value: fs.createReadStream('updater.js'),
        options: {
            filename: 'updater.js',
            contentType: 'text/javascript'
        }
    }]
};

request.post({
    uri: 'http://localhost:1337/upload',
    rejectUnauthorized: false,
    formData: data
}, function (err, response, body) {
    console.log(err || body);
});

RESULT:

message.eml 152598 88462
attachment.gif 63980 60843
updater.js 2979 2979

ls -la

-rw-r--r--    1 dos   staff  60843 Sep 30 19:59 attachment.gif
-rw-r--r--@   1 dos   staff  88462 Sep 30 19:55 message.eml
-rw-r--r--    1 dos   staff   2979 Sep 13 01:32 updater.js

P.S. All will be ok if I post one file in array. If I post two files:

message.eml 149461 88462
attachment.gif 60843 60843

You can see that skipper detects correct size only in last file.

P.S.S. I tested request.js on Hapi and Express.js+multer. They are detects the correct sizes.

[sailsbot]

Hi @NAlexandrov! It looks like you missed a step or two when you created your issue. Please edit your comment (use the pencil icon at the top-right corner of the comment box) and fix the following:

• Provide your Sails version
• Provide your Node version
• Provide your NPM version
• Provide your Operating system

As soon as those items are rectified, post a new comment (e.g. “Ok, fixed!”) below and we'll take a look. Thanks!

If you feel this message is in error, or you want to debate the merits of my existence (sniffle), please contact [email protected].

[mikermcneil]

Hey @NAlexandrov, thanks for the detailed report. @crobinson42 made some progress on this here: https://github.com/balderdashy/skipper/issues/109, so if you'd take a look at his findings and let us know what your results were, that'd be awesome.

[mikermcneil]

@NAlexandrov This is now fixed in the latest skipper-disk and skipper-s3 on NPM (cc @sgress454)