Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLIPPacketSerial send() gives me two 0xc0 as the end of packet #11

Closed
latonita opened this issue Nov 8, 2017 · 4 comments
Closed

SLIPPacketSerial send() gives me two 0xc0 as the end of packet #11

latonita opened this issue Nov 8, 2017 · 4 comments

Comments

@latonita
Copy link
Contributor

latonita commented Nov 8, 2017 •
edited
Loading

I simply do slip.send(buff*,size) and it gives me nice slip packet, but with two 0xc0 in the end instead of one. this makes stream desynchronized and i loose packets on receiving side

I suppose it shall be only one 0xc0 in the end.

what i get:
[0xc0,data,0xc0,0xc0][0xc0,data,0xc0,0xc0]...

what i expect:
[0xc0,data,0xc0][0xc0,data,0xc0]...

thanks
@latonita latonita changed the title SLIPPacketSerial send gives me two 0xc0 in the end of message SLIPPacketSerial send() gives me two 0xc0 as the end of packet Nov 8, 2017
@bakercp
Copy link
Owner

bakercp commented Nov 8, 2017

Hey there, thanks for the report -- can you test this pull request to see if it fixes the issue? I haven't had a chance to test it. If it works, we should just merge it!

#7

@latonita latonita mentioned this issue Nov 8, 2017
Merged
@latonita
Copy link
Contributor Author

latonita commented Nov 9, 2017

@bakercp please review and merge my fix #12

@bakercp
Copy link
Owner

bakercp commented Nov 9, 2017

I'm checking it out now. Thanks!

@bakercp
Copy link
Owner

bakercp commented Nov 9, 2017

I believe everything should be in order now. Please check out the latest release.

Thanks for your contribution.

@bakercp bakercp closed this as completed Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bakercp @latonita