Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle case when not running in a nodejs module dir #284

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

ricksbrown
Copy link
Contributor

Hi there - I am trying to run "start-server-and-test" from npx to kick off a tomcat server (java) and then run some automated tests.

There is no nodejs involved, so there is no package.json, which causes the current version to die.

This change allows "start-server-and-test" to continue without requiring a package.json.

Copy link
Owner

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bahmutov bahmutov changed the title fix: fails when not running in a nodejs module dir fix: handle case when not running in a nodejs module dir Oct 1, 2020
@bahmutov bahmutov merged commit 0d3d11e into bahmutov:master Oct 1, 2020
@github-actions
Copy link

github-actions bot commented Oct 1, 2020

🎉 This PR is included in version 1.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants