Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changelog doesn't use absolute paths #15

Open
229c9cf0 opened this issue Feb 14, 2022 · 1 comment
Open

[BUG] Changelog doesn't use absolute paths #15

229c9cf0 opened this issue Feb 14, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@229c9cf0
Copy link

I have several files with the same name spread across the graph (index / inbox files in various folders / sub-hierarchies, e.g. work/-INBOX-, projects/-INBOX-, ... and a global -INBOX- for quick notes to process later.)

Because the change log link doesn't include the full path, most of these notes get lost / aren't properly tracked by the change log.

Notes should be linked by the full path instead. (There's even an Obsidian option, but I'm not sure if it's accessible or if there's an API call to generate a link according to the current setting. Didn't see anything on the file descriptor itself.)

I locally edited the JS resulting from https://github.com/badrbouslikhin/obsidian-vault-changelog/blob/main/main.ts#L91 to

const path = recentlyEditedFile.path;                                                       
const link = path.substring( 0, path.length - (1+recentlyEditedFile.extension.length) );    
changelogContent += "- " + humanTime + " \u00B7 [[" + link + "]]\n";                        

and that works for me, for now. But others will probably also run into this.

@badrbouslikhin
Copy link
Owner

Apologize for the delay in responding to this issue!

Thanks for reaching out. This is a valid remark, can you please submit a PR?

@badrbouslikhin badrbouslikhin added the bug Something isn't working label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants