fix: icon links are no only with exact rel="ico"

luchoman08 · luchoman08 · commit 81e4889a3780 · 2019-05-14T16:31:33.000-05:00
Some pages now have icons in links with rel="shortcut icon" for example
diff --git a/goscraper.go b/goscraper.go
@@ -197,7 +197,7 @@ func (scraper *Scraper) parseDocument(doc *Document) error {
 				if cleanStr(attr.Key) == "rel" && cleanStr(attr.Val) == "canonical" {
 					canonical = true
 				}
-				if cleanStr(attr.Key) == "rel" && cleanStr(attr.Val) == "icon" {
+				if cleanStr(attr.Key) == "rel" && strings.Contains(cleanStr(attr.Val),  "icon") {
 					hasIcon = true
 				}
 				if cleanStr(attr.Key) == "href" {

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ func (scraper Scraper) parseDocument(doc Document) error {`
`197`	`197`	`if cleanStr(attr.Key) == "rel" && cleanStr(attr.Val) == "canonical" {`
`198`	`198`	`canonical = true`
`199`	`199`	`}`
`200`		`- if cleanStr(attr.Key) == "rel" && cleanStr(attr.Val) == "icon" {`
	`200`	`+ if cleanStr(attr.Key) == "rel" && strings.Contains(cleanStr(attr.Val), "icon") {`
`201`	`201`	`hasIcon = true`
`202`	`202`	`}`
`203`	`203`	`if cleanStr(attr.Key) == "href" {`