Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Pages should not allow scheduling by default #3795

Open
jenlampton opened this issue May 17, 2019 · 11 comments · May be fixed by backdrop/backdrop#3777 or backdrop/backdrop#5000
Open

[UX] Pages should not allow scheduling by default #3795

jenlampton opened this issue May 17, 2019 · 11 comments · May be fixed by backdrop/backdrop#3777 or backdrop/backdrop#5000

Comments

@jenlampton
Copy link
Member

jenlampton commented May 17, 2019

In the standard install profile, the Show option for scheduling setting for Pages should be disabled. (It should remain enabled for Posts)
Screen Shot 2019-05-17 at 4 15 37 PM

Files to change
core/profiles/standard/standard.install, line 123

Documentation
https://docs.backdropcms.org/api/backdrop/core%21profiles%21standard%21standard.install/function/standard_install/1

Related
#3122 separate help text for publishing options

@klonos
Copy link
Member

klonos commented May 19, 2019

I've seen use cases with customers where they'd want the option to schedule publishing of pages (and other content types as well). Any specific reason why we should not allow this by default for all content types?

@jenlampton
Copy link
Member Author

jenlampton commented May 19, 2019 via email

@klonos
Copy link
Member

klonos commented May 19, 2019

Fair enough. Adding the "needs metrics" tag; not for the decision to implement this; just because it will be a good candidate to test #285

@ghost ghost added the type - task label Oct 12, 2020
@mmachinen
Copy link

@stpaultim I would like to work on this issue.

mmachinen added a commit to mmachinen/backdrop that referenced this issue Oct 1, 2021
Fixes backdrop/backdrop-issues#3795
In the standard install profile, the Show option for scheduling setting for Pages should be disabled. (It should remain enabled for Posts)
@klonos
Copy link
Member

klonos commented Oct 7, 2021

Thank you for working on this @mmachinen 🙏🏼 ...there are test failures that need to be fixed, so I'm setting this back to "needs work". It seems to me that things should be fixed in the testPagePreview() function/method, since it seems to be using the page content type in order to test scheduling among other things. I haven't tested, but changing things like these should do it (there might be other additional bits here and there though):

  • $this->backdropPost('admin/structure/types/manage/page', $edit, t('Save content type'));
  • $this->backdropGet('node/add/page');
  • $this->backdropPost('node/add/page', $edit, t('Preview'));

PS: Once #5236 is merged, you should rebase your PR branch (let us know if you need help with that), which should help to display these failures in a better format 😉

@klonos
Copy link
Member

klonos commented Oct 7, 2021

@jenlampton re this:

Because it's uncommon, and not hard to enable.

We're basically trying to remove one of the radio options from this UI here:

I'm not sure how much value this adds, as it doesn't declutter things much. Besides, I'm concerned about making an awesome feature (WordPress parity) less discoverable, plus working with government agencies I see that it is in fact used quite a lot (ministerial announcements that are not necessarily blog posts, new members of the department that need to be announced and added to the team members listing during a specific date/time after elections, new laws/regulations that come into effect after a specific date/time etc.). Perhaps we should reconsider this?

@jenlampton
Copy link
Member Author

jenlampton commented Oct 7, 2021 via email

@klonos
Copy link
Member

klonos commented Oct 8, 2021

Well, the default when creating a new content type is to have the scheduling option shown. So I'm OK with this change here I guess.

@NormPlum
Copy link

Here's a new PR: backdrop/backdrop#5000 Based on the previous PR I assume tests will fail so I'll wait and see what needs fixing then attempt to do so.

@NormPlum
Copy link

Fixed failed test by removing scheduling parts. Confirmed removed parts were duplicated in other tests, so nothing should be lost here.

@stpaultim
Copy link
Member

I certainly don't feel strongly about this. But, I can see where this is not a necessary default option (scheduling pages). In terms of discoverability, having it enabled on posts helps with this and posts are MUCH more likely to be scheduled.

It seems that "cards" are already off by default.

I support this change. We have a PR, so I will add this to the milestone and mark WFM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment