-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong help text in the timezone selector in user edit form #5899
Comments
Simple PR up for review: backdrop/backdrop#4290 Initially, I thought that we should display a different message depending on whether the currently logged-in person is editing their own account or someone else's, by adding a "for this account" or "for your account" at the end of the existing help text. However, after enabling the Language and Locale modules, I saw that we are doing a good job conveying that for the help text in the language selection:
So I went with something similar for the time zone selector as well:
I've removed the "Select the desired local time and time zone." bit, since it states the obvious and doesn't provide any value. |
I like the new wording. Code reviewed. Tested. WFM, LGTM, RTBC (but others might still want to chime in on the wording). |
Thanks @klonos and @bugfolder! I merged this into 1.x only for 1.24.0. |
Why wasn't this in 1.23.2? Does it include new tests? |
I was thinking to minimize string changes, and with 1.24.0 around the corner. |
The text reads:
The user is selecting one thing: timezone - not local time. Also, if you view the second sentence from an admin point of view (while editing another person's user account), it sounds as if this setting will affect everything on the site, whereas this will only affect the user for the account being edited.
The text was updated successfully, but these errors were encountered: