Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace double dashes with middot in Taxonomy fields #4770

Closed
ghost opened this issue Nov 24, 2020 · 8 comments · Fixed by backdrop/backdrop#3410
Closed

Replace double dashes with middot in Taxonomy fields #4770

ghost opened this issue Nov 24, 2020 · 8 comments · Fixed by backdrop/backdrop#3410

Comments

@ghost
Copy link

ghost commented Nov 24, 2020

Similar to #4218, we should be consistent and change dashes in Taxonomy fields to middots as well.

@ghost
Copy link
Author

ghost commented Nov 24, 2020

Here's a PR: backdrop/backdrop#3410

@indigoxela
Copy link
Member

Nice catch. The PR fixes it on the field settings and node form. What's still missing is the term/add (and edit) form:
term-add-edit

(In taxonomy.admin.inc I suppose.) I didn't check views yet.

@ghost
Copy link
Author

ghost commented Nov 24, 2020

Thanks @indigoxela, PR updated.

@klonos
Copy link
Member

klonos commented Nov 24, 2020

@ghost
Copy link
Author

ghost commented Nov 24, 2020

PR updated (again).

@indigoxela
Copy link
Member

PR updated (again).

Many thanks, I think we now really catched them all.

Tested with:

  • admin/structure/taxonomy/category/add
  • admin/structure/types/manage/post/fields/field_category
  • node/add/post
  • a test view with an exposed filter as a dropdown (with hierarchy)

Works for me.

@klonos
Copy link
Member

klonos commented Nov 24, 2020

I think we now really catched them all.

Yup, I think so too 👍

Same as #4218, this is a task; not a feature request. I've added the milestone candidate label accordingly, so if a second person agrees, please set the milestone too 😉

@ghost
Copy link
Author

ghost commented Nov 24, 2020

Thanks guys. I've merged backdrop/backdrop#3410 into 1.x and 1.17.x.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants