Issue #38: Add aria attributes with approproate warning for new windows.

Jen Lampton · Jen Lampton · commit 159f41d31b21 · 2022-11-21T15:14:01.000-08:00
diff --git a/on_the_web.theme.inc b/on_the_web.theme.inc
@@ -33,10 +33,12 @@ function theme_on_the_web_item($variables) {
   $attributes  = array(
     'class' => $link_classes,
     'title' => $title,
+    'aria-label' => $title,
     'rel' => 'nofollow',
   );
   if ($target == TRUE) {
     $attributes['target'] = '_blank';
+    $attributes['aria-label'] .= ' (' . t('opens in new window') . ')';
   }
   $options = array('attributes' => $attributes, 'html' => TRUE);
 
@@ -65,7 +67,7 @@ function theme_on_the_web_item($variables) {
     $icon_classes[] = 'fa-2x';
   }
 
-  $text = '<i class="' . implode(' ', $icon_classes) . '"></i>';
+  $text = '<i aria-hidden="true" class="' . implode(' ', $icon_classes) . '"></i>';
 
   return l($text, $link, $options);
 }

Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,12 @@ function theme_on_the_web_item($variables) {`
`33`	`33`	`$attributes = array(`
`34`	`34`	`'class' => $link_classes,`
`35`	`35`	`'title' => $title,`
	`36`	`+ 'aria-label' => $title,`
`36`	`37`	`'rel' => 'nofollow',`
`37`	`38`	`);`
`38`	`39`	`if ($target == TRUE) {`
`39`	`40`	`$attributes['target'] = '_blank';`
	`41`	`+ $attributes['aria-label'] .= ' (' . t('opens in new window') . ')';`
`40`	`42`	`}`
`41`	`43`	`$options = array('attributes' => $attributes, 'html' => TRUE);`
`42`	`44`
`@@ -65,7 +67,7 @@ function theme_on_the_web_item($variables) {`
`65`	`67`	`$icon_classes[] = 'fa-2x';`
`66`	`68`	`}`
`67`	`69`
`68`		`- $text = '<i class="' . implode(' ', $icon_classes) . '"></i>';`
	`70`	`+ $text = '<i aria-hidden="true" class="' . implode(' ', $icon_classes) . '"></i>';`
`69`	`71`
`70`	`72`	`return l($text, $link, $options);`
`71`	`73`	`}`