Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v4 shims with v5 #15

Closed
bugfolder opened this issue Jan 6, 2022 · 4 comments · Fixed by #20
Closed

Add support for v4 shims with v5 #15

bugfolder opened this issue Jan 6, 2022 · 4 comments · Fixed by #20

Comments

@bugfolder
Copy link
Contributor

FontAwesome v5 renamed some icons, which breaks some v4 icon names. But FontAwesome also provides a shim file that restores compatiblity with v4 while allowing one to use all the goodness of v5. It would be nice to offer that as a option, which the attached PR does.

To see the difference, put this code in a page and compare the 3 configuration settings:

<p>
FontAwesome 4 icons (bandcamp, cart): <i class="fa fa-bandcamp"></i>, <i class="fa fa-shopping-cart"></i>
</p>

<p>
FontAwesome 5 icons (bandcamp, cart): <i class="fab fa-bandcamp"></i>, <i class="fas fa-shopping-cart"></i>
</p>

"v4" and "v5" don't display all of the icons, but the "v5 + shims" option will display both pairs of icons.

fontawesome

@yorkshire-pudding
Copy link
Collaborator

Hi @bugfolder - Thank you for your contribution and sorry it has sat ignored for so long.
I've just taken over the maintainer-ship of this module so it doesn't get too neglected. Your change looks mostly good, but needs a rebase (after #11) and it probably makes sense (if the shims work with that version) to update it to 5.15.4 or could match the versions with shims if that works; up to you.

Thanks

@bugfolder
Copy link
Contributor Author

I rebased in a new PR.

I observe that now there are two v5 options: v5.2 and v5.15. That suggests that instead of making the shim option one of the radio buttons, the shim choice should be a separate checkbox that would apply to either of the v5 options (and/or any future v5 additions). Would you agree? If so, I'll update the PR.

@yorkshire-pudding
Copy link
Collaborator

@bugfolder - Yes - that makes sense. Thank you

@bugfolder
Copy link
Contributor Author

PR updated, ready for review.

yorkshire-pudding added a commit that referenced this issue May 22, 2023
Issue #15: Add v4 shims option with v5 FontAwesome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants