-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for v4 shims with v5 #15
Comments
Hi @bugfolder - Thank you for your contribution and sorry it has sat ignored for so long. Thanks |
I rebased in a new PR. I observe that now there are two v5 options: v5.2 and v5.15. That suggests that instead of making the shim option one of the radio buttons, the shim choice should be a separate checkbox that would apply to either of the v5 options (and/or any future v5 additions). Would you agree? If so, I'll update the PR. |
@bugfolder - Yes - that makes sense. Thank you |
PR updated, ready for review. |
Issue #15: Add v4 shims option with v5 FontAwesome.
FontAwesome v5 renamed some icons, which breaks some v4 icon names. But FontAwesome also provides a shim file that restores compatiblity with v4 while allowing one to use all the goodness of v5. It would be nice to offer that as a option, which the attached PR does.
To see the difference, put this code in a page and compare the 3 configuration settings:
"v4" and "v5" don't display all of the icons, but the "v5 + shims" option will display both pairs of icons.
The text was updated successfully, but these errors were encountered: