Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pspm_find_sounds #206

Open
teddychao opened this issue Mar 22, 2021 · 1 comment
Open

Improve pspm_find_sounds #206

teddychao opened this issue Mar 22, 2021 · 1 comment
Assignees
Labels
Conceptional The pull request includes conceptional updates
Milestone

Comments

@teddychao
Copy link
Contributor

Feature Description

  • Split the new section into at least a local function;
  • Resolve the namespace issues and improve the readability of variable names;
  • Generalise pspm_find_sounds if possible, add extra sub functions if needed.
@teddychao teddychao added the Improvement A minor improvement to the project label Mar 22, 2021
@teddychao teddychao added this to the v5.1.0 milestone Mar 22, 2021
@teddychao teddychao self-assigned this Mar 22, 2021
@teddychao teddychao modified the milestones: v5.1.0, v5.2.0 Jun 7, 2021
@teddychao teddychao modified the milestones: v5.2.0, v6.0.0 Jan 24, 2022
@teddychao
Copy link
Contributor Author

This issue is rather complicated thus I would recommend to include in v6.1.

@teddychao teddychao modified the milestones: v6.0, v6.1 May 31, 2022
@teddychao teddychao modified the milestones: v6.1, v6.2 Aug 20, 2023
@teddychao teddychao modified the milestones: v6.1.1, v6.2 Jan 22, 2024
@teddychao teddychao added Conceptional The pull request includes conceptional updates and removed Improvement A minor improvement to the project labels Mar 11, 2024
@teddychao teddychao modified the milestones: v6.2, v7.0 Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conceptional The pull request includes conceptional updates
Projects
None yet
Development

No branches or pull requests

1 participant