Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt x/btcstaking unit tests to pre-approval flow #119

Closed
KonradStaniec opened this issue Oct 2, 2024 · 2 comments · Fixed by #137
Closed

Adapt x/btcstaking unit tests to pre-approval flow #119

KonradStaniec opened this issue Oct 2, 2024 · 2 comments · Fixed by #137
Assignees

Comments

@KonradStaniec
Copy link
Collaborator

after: #117

Most x/btcstaking tests still assume old flow. We need to adapt them to new flow, and test both paths. This is also good ocasion to refactor x/btcstaking message handlers

@SebastianElvis
Copy link
Member

Since we are doing this, what do you think about merging the test util under x/btcstaking with the test framework at https://github.com/babylonlabs-io/babylon/blob/544386204a860ee7159923b3d34174d0cf8c6049/testutil/helper, and use this framework for testing everything? This way we get rid of many mock tests

@KonradStaniec
Copy link
Collaborator Author

you mean get rid of https://github.com/babylonlabs-io/babylon/blob/main/x/btcstaking/keeper/keeper_test.go#L30 ? Tbh sounds great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants