-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adapt tests to the pre-approval flow #137
Conversation
ah we wanted to specifically avoid the word
|
Actually I thought the opposite: covenant committee indeed approves BTC delegations, and they can selectively approve and disapprove. Hence the feature we are adding is called pre-approval. Although I agree that the word does not sound right politically. Let me change it back (UPDATE: fixed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #121
Resolves #119
This PR adapts the tests under
x/btcstaking
to the pre-approval flow. This includesh.CreateDelegation
function to support both pre-approval and non-pre-approval flowIn addition, this PR proposes to rename statusAlso this PR fixes the flakyVERIFIED
toAPPROVED
for clarity: verified is a bit generic while approved is more consistent with existing terms (pre-"approval").FuzzBTCDelegation
test (checked the fix via fuzzing locally).