Support static class blocks when _not_ using an explicit babel config file. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Oct 3, 2023
ef4
approved these changes
Oct 7, 2023
NullVoxPopuli
deleted the
support-non-explicit-babel-config-for-static-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #502
Support for static blocks was added only when using an explicit babel config.
This PR adds the implicit / default support that most folks would use in today's ember apps.
I had missed this because I didn't, at the time, know that the paths for generating which babel plugins we need between the two setups (with and without a babel config) use separate code.
Unblocks: ember-cli/ember-template-imports#187