Ensure that plugin-transform-class-static-block is provided #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failures look to be due to network issues |
NullVoxPopuli
force-pushed
the
ensure-that-transform-class-static-block-is-provided
branch
from
6043ea8
to
2386fc5
Compare
ef4
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
This looks good to me.
It's yet another required transform when using legacy decorators, so not really any new policy choice here.
While we talked about getting this into 8.0.1 (which just shipped), I think it's better that we wanted so this can be a minor instead, as this adds a new capability.
NullVoxPopuli
deleted the
ensure-that-transform-class-static-block-is-provided
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this issue while working on: ember-cli/ember-template-imports#187
I tested over on that branch locally by editing the node_modules directly.
The test suite here in ember-cli-babel can't be trusted because
@babel/plugin-transform/class-static-blockwas picked up automatically due to how bad yarn@v1's hoisting is -- the static-block plugin was resolved via@babel/preset-env-- preset-env does not inherently provide static-blocks -- it must be configured when we compile away class properties.If this repo were to switch to using a real package manager, the the static test would fail without the corresponding change in
lib/ember-plugins.js