Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade all the deps #144

Merged
merged 1 commit into from
May 16, 2017
Merged

upgrade all the deps #144

merged 1 commit into from
May 16, 2017

Conversation

stefanpenner
Copy link
Member

No description provided.

.travis.yml Outdated
- npm test
# Usually, it's ok to finish the test scenario without reverting
# to the addon's original dependency state, skipping "cleanup".
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will result in us not actually running the node tests?

.travis.yml Outdated

env:
# we recommend testing LTS's and latest stable release (bonus points to beta/canary)
- EMBER_TRY_SCENARIO=ember-lts-2.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no ember specific code here, I don't think we need to test more than one (slowing down CI runs...)

.travis.yml Outdated
- "6"
- "7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to continue to test against 4, 6, and 7.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@stefanpenner
Copy link
Member Author

@rwjblue thanks for the review, should be addressed now!

@rwjblue rwjblue merged commit 65038c7 into master May 16, 2017
@stefanpenner stefanpenner deleted the update branch May 31, 2017 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants