Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies & replace pify #884

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Upgrade dependencies & replace pify #884

merged 2 commits into from
Nov 18, 2020

Conversation

realityking
Copy link
Contributor

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Dependency upgrades

What is the current behavior? (You can also link to an open issue here)

babel-loader is loading older dependencies than necessary

What is the new behavior?

babel-loader is loading the newest possible dependency

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

Since #882 raised the minimum Node version to 8.9 some dependency updates & replacements are now possible.

Note I didn't update loader-utils to version 2 since not even Webpack@5 is using it. I'm not sure what's going on with that package. Also schema-utils version3 requires Node.js 10.13 and thus can't be upgraded.

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit 534ec84 into babel:main Nov 18, 2020
@realityking realityking deleted the node-8-deps branch November 18, 2020 19:26
@realityking
Copy link
Contributor Author

@JLHwung Any chance to push this out as a patch release? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants