Breaking: make AST match Espree 6

[golopot]

This is a breaking change that change the baseline to espree 6.

Some node types has changes in accordance with changes in espree:

• ExperimentalSpreadProperty became SpreadElement.
• ExperimentalRestProperty became RestElement.
• Literal became JSXText (for JSXText).

fixes #759

[kaicataldo]

Can we mark this as a breaking change rather than a feature? Since v11 is still in development, I would advocate for releasing this in v11.

Also, can we add some tests for these changes?

[kaicataldo]

IsArray{Pattern|Expression} already taken care of?

[golopot]

Yes.

babel-eslint/test/specs/babel-eslint.js

Lines 485 to 495 in 2540427

	it("RestOperator", () => {
	parseAndAssertSame("var { a, ...b } = c");
	parseAndAssertSame("var [ a, ...b ] = c");
	parseAndAssertSame("var a = function (...b) {}");
	});
	it("SpreadOperator", () => {
	parseAndAssertSame("var a = { b, ...c }");
	parseAndAssertSame("var a = [ a, ...b ]");
	parseAndAssertSame("var a = sum(...b)");
	});

[kaicataldo]

Great, thanks - makes sense!

[golopot]

Can we mark this as a breaking change rather than a feature?

How about this commit message title?
Breaking: update to espree@6

Also, can we add some tests for these changes?

The old tests has covered the changes. The function parseAndAssertSame compare the ast generated by babel and espree.

babel-eslint/test/specs/babel-eslint.js

Lines 485 to 495 in 2540427

	it("RestOperator", () => {
	parseAndAssertSame("var { a, ...b } = c");
	parseAndAssertSame("var [ a, ...b ] = c");
	parseAndAssertSame("var a = function (...b) {}");
	});
	it("SpreadOperator", () => {
	parseAndAssertSame("var a = { b, ...c }");
	parseAndAssertSame("var a = [ a, ...b ]");
	parseAndAssertSame("var a = sum(...b)");
	});

[kaicataldo]

LGTM!

[kaicataldo]

Great, thanks - makes sense!

[kentcdodds]

I'm not sure how we're managing the alpha release. Should this be merged into master, or into some interim branch?

[kaicataldo]

I'm not sure either - hopefully someone from the core Babel team can help us out here!

[golopot]

v11 works are already present in master, so I suppose v11 development happens in master. And v10 development be done in branch 10.x.

[kaicataldo]

Friendly ping @nicolo-ribaudo (just because you gave a thumbs up above 😄). This seems like a good thing to land in v11 to me, but would love input from the core team!

[kaicataldo]

One more friendly ping here. Our last release ended up causing one of the core rules to crash with babel-eslint because I mistakenly removed a check for ExperimentalRestProperty nodes 😬. Aligning the AST here would help prevent those kinds of bugs going forward!

[hzoo]

Ok sounds good. Mostly removing the things we had before for compat and now aren't.

[kaicataldo]

Friendly ping - is this something we can merge?

[existentialism]

Do we want to ship 11 and this as 12? Or just lump it in?

[kaicataldo]

I think it's fine to lump this in with 11 since it's still in beta.

[existentialism]

@kaicataldo let's do it