Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assignee (reviewer) to PRs #2

Open
xtuc opened this issue Jan 8, 2017 · 1 comment
Open

Add assignee (reviewer) to PRs #2

xtuc opened this issue Jan 8, 2017 · 1 comment
Labels

Comments

@xtuc
Copy link
Member

xtuc commented Jan 8, 2017

The Facebook/mention-bot offers a programmatic API (source).

It think we could easily integrate it in the Babel-bot.

Usage example:

mentionBot
  .guessOwnersForPullRequest(
    'https://github.com/babel/babel', // repo
    65, // pull request number
    'babel-bot', // user that created the pull request
    'master', // branch
    { maxReviewers: 3 }, // config
    [...]
  )
  .then(function(users) {
    // array with user names which should be included in review
    console.log(users);
  })
  .catch(function(err) {
    console.error(err);
  });

It will be triggered in src/handlers/pull_request/opened.js.

Instead of babel/babel#5057

@xtuc xtuc added the question label Jan 8, 2017
@hzoo hzoo changed the title Add reviewer to PRs Add assignee (reviewer) to PRs Jan 12, 2017
@DrewML
Copy link
Member

DrewML commented Jan 15, 2017

Let's keep using the free hosted version for now, to save on costs for the babel-bot Lambda function. We can always switch over later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants