Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0 breaks our usage of browser-sync #50

Closed
tbassetto opened this issue Nov 21, 2016 · 4 comments
Closed

v1.1.0 breaks our usage of browser-sync #50

tbassetto opened this issue Nov 21, 2016 · 4 comments

Comments

@tbassetto
Copy link

[browser-sync](https://github.com/Browsersync/browser-sync) depends on portscanner ^1.0.0 so it now downloads 1.1.0. Is there a changelog available? Serving our app crashes (without a meaningful message) unless we force install portscanner 1.0.0. There must be a breaking change somewhere.

@laggingreflex
Copy link
Collaborator

laggingreflex commented Nov 21, 2016

Extremely sorry about introducing a breaking change in a minor version.

I've reverted it to 1.0.0 which is now published as 1.1.1

The previous new version is now published as 2.0.0

@laggingreflex
Copy link
Collaborator

laggingreflex commented Nov 21, 2016

I'm trying to reproduce the error, could you please let me know how you're using Browsersync? CLI doesn't seem to be affected, does it? I've also ran all its tests with portscanner 1.1.0 and they seem to be passing.

@laggingreflex
Copy link
Collaborator

Hopefully fixed now. See #51 for details

@tbassetto
Copy link
Author

Yes, 1.2.0 fixed the bug we were experiencing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants