-
Notifications
You must be signed in to change notification settings - Fork 0
Rewrite in pure Python #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When run with the proper .env file: 7 failed, 142 passed, 2 skipped, 1 warning - Critical naming fix - Update .proto files - Add script to update .proto files - Ditch HTTP impl - Improve manifest and encrypt test - Python CLI decrypt now works correctly with TDF files created by otdfctl
Cleanup tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨🪩✨ New and Improved! ✨🪩✨
This pull request rewrites this library in "pure python" (of course, using the
cryptographylibrary means that Rust is used under the hood for crypto).In this PR, we introduce a simplified, modernized toolchain. In particular, the CI pipeline and local development is improved using using the
uvtool. The most important changes are grouped below.Build and Test Improvements:
Switches to
uvfor Python environment management.Switches to building a sub-module using
bufand generating Connect RPC client code.buf#45bufbuild #50Maintains and expands integration testing: separates unit and integration tests (can now be run with
uv run pytest, and can execute tests with clear markers).Cleanup and Redundancy Removal:
gopytoolingThese changes significantly simplify the CI/CD process, improve maintainability, and align the workflows with modern Python tooling and best practices.
TODO
getattrandkwargs_get_token_from_client_credentials)realm_name = "opentdf"cibuildwheelcomponents for multi-arch distribution, and upload built wheels to PyPITODO (nice to have)
self.issuer_endpoint, to align more closely with Java SDK's SDKBuilder.java (getplatform_issuerfrom well known configuration)ruffrules ( e.g."D"for pydocstyle [ docstring conventions] )