Skip to content

Commit 7fd063b

Browse files
committed
Remove the duplicate integration-test job
1 parent c92d77f commit 7fd063b

File tree

5 files changed

+18
-59
lines changed

5 files changed

+18
-59
lines changed

.github/workflows/build-python.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,8 @@ on:
77
pull_request:
88

99
jobs:
10-
# Run comprehensive test suite first (fail fast)
11-
test-suite:
12-
uses: ./.github/workflows/test-suite.yaml
13-
1410
build:
1511
runs-on: ubuntu-22.04
16-
needs: test-suite
17-
if: needs.test-suite.outputs.tests_passed == 'true'
1812
outputs:
1913
wheel: ${{ steps.find_wheel.outputs.wheel_path }}
2014
steps:

.github/workflows/publish-test.yaml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,12 @@ on:
66
- develop
77
- chore/update-docs-and-release-process
88
repository_dispatch:
9-
types: [alpha-release-created]
9+
types: [alpha-release-created, stable-release-created]
1010
workflow_dispatch:
1111

1212
jobs:
13-
# Run full test suite before any publishing operations
14-
test-suite:
15-
uses: ./.github/workflows/test-suite.yaml
16-
1713
build:
1814
name: Build Python Package
19-
needs: test-suite
20-
if: needs.test-suite.outputs.tests_passed == 'true'
2115
runs-on: ubuntu-22.04
2216
steps:
2317
- uses: actions/checkout@v4

.github/workflows/publish.yaml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,12 @@ on:
44
release:
55
types: [published]
66
repository_dispatch:
7-
types: [stable-release-created]
7+
types: [alpha-release-created, stable-release-created]
88
workflow_dispatch:
99

1010
jobs:
11-
# Run full test suite before any publishing operations
12-
test-suite:
13-
uses: ./.github/workflows/test-suite.yaml
14-
1511
build_macos:
1612
name: MacOS ${{ matrix.os_version }} Python 3${{ matrix.python3_version }} ${{ matrix.arch_cibw_go[0] }}
17-
needs: test-suite
18-
if: needs.test-suite.outputs.tests_passed == 'true'
1913
strategy:
2014
fail-fast: false
2115
matrix:
@@ -49,8 +43,6 @@ jobs:
4943

5044
build_linux_x86_64:
5145
name: Linux Python x86_64
52-
needs: test-suite
53-
if: needs.test-suite.outputs.tests_passed == 'true'
5446
runs-on: ubuntu-22.04
5547
steps:
5648
- uses: actions/checkout@v4
@@ -76,8 +68,6 @@ jobs:
7668

7769
build_linux_arm:
7870
name: Linux Python ARM
79-
needs: test-suite
80-
if: needs.test-suite.outputs.tests_passed == 'true'
8171
runs-on: ubuntu-22.04
8272
timeout-minutes: 60
8373
steps:

.github/workflows/release-please.yaml

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
push:
55
branches:
66
- main
7+
- develop
78
workflow_dispatch:
89

910
permissions:
@@ -51,29 +52,20 @@ jobs:
5152
echo "Stable version detected: $VERSION"
5253
fi
5354
54-
# For alpha versions: trigger TestPyPI build (develop branch workflow)
55-
- name: Trigger TestPyPI Build (Alpha)
56-
if: steps.check_alpha.outputs.is_alpha == 'true'
55+
# For develop branch: trigger TestPyPI build (both alpha and stable releases go to TestPyPI from develop)
56+
- name: Trigger TestPyPI Build (Develop)
57+
if: github.ref == 'refs/heads/develop'
5758
uses: peter-evans/repository-dispatch@v3
5859
with:
5960
token: ${{ secrets.GITHUB_TOKEN }}
60-
event-type: alpha-release-created
61+
event-type: ${{ steps.check_alpha.outputs.is_alpha == 'true' && 'alpha-release-created' || 'stable-release-created' }}
6162
client-payload: '{"version": "${{ steps.check_alpha.outputs.version }}", "releases": "${{ needs.release-please.outputs.paths_released }}"}'
6263

63-
# For alpha versions: also trigger main PyPI build
64-
- name: Trigger PyPI Build (Alpha)
65-
if: steps.check_alpha.outputs.is_alpha == 'true'
64+
# For main branch: trigger PyPI build (both alpha and stable releases go to PyPI from main)
65+
- name: Trigger PyPI Build (Main)
66+
if: github.ref == 'refs/heads/main'
6667
uses: peter-evans/repository-dispatch@v3
6768
with:
6869
token: ${{ secrets.GITHUB_TOKEN }}
69-
event-type: stable-release-created
70-
client-payload: '{"version": "${{ steps.check_alpha.outputs.version }}", "releases": "${{ needs.release-please.outputs.paths_released }}"}'
71-
72-
# For stable versions: only trigger main PyPI build
73-
- name: Trigger PyPI Build (Stable)
74-
if: steps.check_alpha.outputs.is_alpha == 'false'
75-
uses: peter-evans/repository-dispatch@v3
76-
with:
77-
token: ${{ secrets.GITHUB_TOKEN }}
78-
event-type: stable-release-created
70+
event-type: ${{ steps.check_alpha.outputs.is_alpha == 'true' && 'alpha-release-created' || 'stable-release-created' }}
7971
client-payload: '{"version": "${{ steps.check_alpha.outputs.version }}", "releases": "${{ needs.release-please.outputs.paths_released }}"}'

.github/workflows/test-suite.yaml

Lines changed: 7 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
name: Test Suite
22

33
on:
4+
push:
5+
branches:
6+
- main
7+
- develop
8+
pull_request:
49
workflow_call:
510
outputs:
611
tests_passed:
@@ -81,14 +86,12 @@ jobs:
8186
uv run pytest -m "not integration" --tb=short -v tests/
8287
8388
# Step 4: Integration tests (only after unit tests pass)
84-
# Only run integration tests on workflow calls (e.g., releases)
8589
integration-tests:
8690
strategy:
8791
fail-fast: true
8892
matrix:
8993
python3_version: ["3.10", "3.11", "3.12", "3.13"]
9094
needs: [build, unit-tests]
91-
if: github.event_name == 'workflow_call' || github.event_name == 'workflow_dispatch'
9295
uses: ./.github/workflows/platform-integration-test.yaml
9396
with:
9497
wheel: ${{ needs.build.outputs.wheel }}
@@ -104,23 +107,9 @@ jobs:
104107
- name: Check all jobs succeeded
105108
id: check
106109
run: |
107-
# Integration tests should always run and succeed in workflow_call/workflow_dispatch contexts
108-
integration_result="${{ needs.integration-tests.result }}"
109-
if [[ "$integration_result" != "success" ]]; then
110-
echo "❌ Integration tests failed or didn't run as expected"
111-
echo "Debug info:"
112-
echo " Event: ${{ github.event_name }}"
113-
echo " Ref: ${{ github.ref }}"
114-
echo " Integration result: $integration_result"
115-
echo " Lint Check: ${{ needs.lint-check.result }}"
116-
echo " Build: ${{ needs.build.result }}"
117-
echo " Unit Tests: ${{ needs.unit-tests.result }}"
118-
exit 1
119-
fi
120-
121-
if [[ "${{ needs.lint-check.result }}" == "success" && "${{ needs.build.result }}" == "success" && "${{ needs.unit-tests.result }}" == "success" && "$integration_result" == "success" ]]; then
110+
if [[ "${{ needs.lint-check.result }}" == "success" && "${{ needs.build.result }}" == "success" && "${{ needs.unit-tests.result }}" == "success" && "${{ needs.integration-tests.result }}" == "success" ]]; then
122111
echo "success=true" >> $GITHUB_OUTPUT
123-
echo "✅ All required tests passed!"
112+
echo "✅ All tests passed!"
124113
else
125114
echo "success=false" >> $GITHUB_OUTPUT
126115
echo "❌ Some tests failed:"

0 commit comments

Comments
 (0)