feat: safer handling of partially staged files #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Partially staged files are not re-staged + Non-zero exit code upon reformatting partially staged file + Update README
azz
reviewed
May 18, 2018
| onWriteFile: file => { | ||
| console.log(`✍️ Fixing up ${chalk.bold(file)}.`); | ||
| }, | ||
| }) | ||
| ); | ||
|
|
||
| console.log('✅ Everything is awesome!'); |
There was a problem hiding this comment.
Oh no, everything is no longer unconditionally awesome 😱
|
This seems like an approach worth trying. Thanks for implementing it! |
|
Sweet, thanks for the pretty-quick turnaround! |
This was referenced May 18, 2018
mpareja
pushed a commit
to mpareja/pretty-quick
that referenced
this pull request
May 22, 2018
+ Partially staged files are not re-staged + Non-zero exit code upon reformatting partially staged file + Update README
azz
pushed a commit
that referenced
this pull request
May 22, 2018
* feat: safer handling of partially staged files (#29) + Partially staged files are not re-staged + Non-zero exit code upon reformatting partially staged file + Update README * Fixes #30 handling of partially staged files The git command checking for unstaged changes should not have been including a revision.
This was referenced May 24, 2018
This was referenced Jun 6, 2018
This was referenced Jun 16, 2018
This was referenced Jul 6, 2018
This was referenced Jul 14, 2018
This was referenced Jul 23, 2018
This was referenced Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially staged files are not re-staged
Non-zero exit code upon reformatting partially staged file
Update README
(From the README: Partially staged files will not be re-staged after formatting and pretty-quick will exit with a non-zero exit code. The intent is to abort the git commit and allow the user to amend their selective staging to include formatting fixes.)