Ignore Path flag #115
Ignore Path flag #115
Conversation
|
@azz, could you please review this new feature |
There was a problem hiding this comment.
Hey @roggervalf, thanks for the PR!
Would you be able to add a test for this?
src/index.js
Outdated
| @@ -15,6 +15,7 @@ export default ( | |||
| branch, | |||
| bail, | |||
| check, | |||
| ignorePath = '.prettierignore', | |||
There was a problem hiding this comment.
Should still work if you just do this? (As the undefined value will get overwritten inside createIgnorer.)
| ignorePath = '.prettierignore', | |
| ignorePath, |
src/index.js
Outdated
| @@ -35,7 +36,7 @@ export default ( | |||
|
|
|||
| onFoundSinceRevision && onFoundSinceRevision(scm.name, revision); | |||
|
|
|||
| const rootIgnorer = createIgnorer(directory); | |||
| const rootIgnorer = createIgnorer(directory, ignorePath); | |||
| const cwdIgnorer = | |||
| currentDirectory !== directory | |||
| ? createIgnorer(currentDirectory) | |||
There was a problem hiding this comment.
May as well pass in ignorePath here too, in case someone is running prettier not in the git root directory and has ignorePath set relative to a subdirectory.
| ? createIgnorer(currentDirectory) | |
| ? createIgnorer(currentDirectory, ignorePath) |
|
Definitely give me a @-mention to grab my attention because I'm drowning in notifications right now... |
|
@azz I addressed your comments, could you please look at these new changes? |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adding new flag to define a custom path for ignore files since prettier also could define a custom path to defines those patters to skip.