Issue 21 エラーメッセージの改善 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
エラー時何調の文体を期待しているか明確にした。 「〜が〜調」→「〜調の文体に、次の〜調の箇所があります: 〜」 textlint-ja#21
Clean up temporary Dockerfile for non Node.js env
|
@azu さま エラー発生（要修正箇所）の行番号・列番号の表示はレベルが高すぎて実装できませんでした。 おてすきにレビューをお願いいたします。 |
|
マージありがとうございます！やった！ |
|
おっとー、README.md がメッセージ内容の変更に追随してませんでした。別途 PR いたします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #21 対応開始の意思表示のため Draft PR をあげました。
当方の開発環境に Node.js をローカルで入れられないため Dockerfile を暫定的に追加しましたが、Draft を解除（レビュー＆マージ依頼）する際に削除して PR いたします。
Node.js 初心者＆初 node.js の PR です。途中、気になる点や問題ありましたらご指摘いただければ嬉しいです。