Support private packages #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
Apr 12, 2018
| const viewPackage = packageName => { | ||
| return new Promise((resolve, reject) => { | ||
| const view = spawn("npm", ["view", packageName, "versions", "--json"]); | ||
| let result = ""; |
There was a problem hiding this comment.
Add errorResult like
let errorResult = "";
lib/can-npm-publish.js
Outdated
| }); | ||
|
|
||
| view.stderr.on("data", err => { | ||
| console.error(err.toString()); |
lib/can-npm-publish.js
Outdated
|
|
||
| view.on("close", code => { | ||
| if (code > 0) { | ||
| reject(); |
There was a problem hiding this comment.
reject(new Error(errorResult));We should reject with errorResult, becausereject should have Error arguments.
This error message will be output to
Line 39 in e8ea937
|
@azu Thanks for your feedback, I updated the PR accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case your packages require you to login to npm using their cli,
can-npm-publishwon't see them (instead getting a 404 withnode-fetch). I changed the check to usenpm viewas suggested in #1