From ad0471e53c6eac801f5bea428044ce0068426fe9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefano=20Borz=C3=AC?= Date: Fri, 17 Mar 2023 14:54:44 +0100 Subject: [PATCH 1/5] doc: windows 7 or older versions are not officially supported --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 48cbd07eba..13b6f2b925 100644 --- a/README.md +++ b/README.md @@ -43,6 +43,8 @@ To use Keira3, you don't need to install any dependency. Just [download](https:/ If you are using Arch Linux you can find the package on [AUR](https://aur.archlinux.org/packages/keira3/) +:warning: [Windows 7 or older Windows versions](https://github.com/azerothcore/Keira3/issues/2212) are not officially supported. + ## How to run Keira3 in development mode ### Dependencies @@ -64,7 +66,7 @@ Please follow [Angular-cli documentation](https://github.com/angular/angular-cli npm install -g @angular/cli ``` -Only for **Windows**, install windows-build-tools as administrator: +Only for **Windows** ([Windows 7 or older versions](https://github.com/azerothcore/Keira3/issues/2212) are not officially supported), install windows-build-tools as administrator: ``` npm install --global-production windows-build-tools ``` From 6c197f80eaf4e26ef89d6b09671f4dde759ad497 Mon Sep 17 00:00:00 2001 From: Helias Date: Fri, 17 Mar 2023 15:01:10 +0100 Subject: [PATCH 2/5] ci: ignore markdown files changes --- .github/workflows/build-linux.yml | 4 ++++ .github/workflows/build-mac.yml | 4 ++++ .github/workflows/build-windows.yml | 4 ++++ .github/workflows/main.yml | 4 ++++ .github/workflows/windows.yml | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 1729122a26..a4013a18e8 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -3,7 +3,11 @@ on: push: branches: - 'master' + paths-ignore: + - "**/*.md" pull_request: + paths-ignore: + - "**/*.md" jobs: build: diff --git a/.github/workflows/build-mac.yml b/.github/workflows/build-mac.yml index 14e5e96cc1..0926b15ea4 100644 --- a/.github/workflows/build-mac.yml +++ b/.github/workflows/build-mac.yml @@ -3,7 +3,11 @@ on: push: branches: - 'master' + paths-ignore: + - "**/*.md" pull_request: + paths-ignore: + - "**/*.md" jobs: build: diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 25be59d4cf..56646af069 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -3,7 +3,11 @@ on: push: branches: - 'master' + paths-ignore: + - "**/*.md" pull_request: + paths-ignore: + - "**/*.md" jobs: build: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index dfc900c3d6..11b9faf73d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -3,7 +3,11 @@ on: push: branches: - 'master' + paths-ignore: + - "**/*.md" pull_request: + paths-ignore: + - "**/*.md" jobs: build: diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 68bc4a3891..3718977a8a 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -3,7 +3,11 @@ on: push: branches: - 'master' + paths-ignore: + - "**/*.md" pull_request: + paths-ignore: + - "**/*.md" jobs: build: From abf7f98e9c1f5650db9f69b51da3e1c3e42099cb Mon Sep 17 00:00:00 2001 From: Helias Date: Fri, 17 Mar 2023 15:02:13 +0100 Subject: [PATCH 3/5] ci: ignore README.md --- .github/workflows/build-linux.yml | 4 ++-- .github/workflows/build-mac.yml | 4 ++-- .github/workflows/build-windows.yml | 4 ++-- .github/workflows/main.yml | 4 ++-- .github/workflows/windows.yml | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index a4013a18e8..522460bcfa 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "**/*.md" + - "README.md" pull_request: paths-ignore: - - "**/*.md" + - "README.md" jobs: build: diff --git a/.github/workflows/build-mac.yml b/.github/workflows/build-mac.yml index 0926b15ea4..bfdf851a26 100644 --- a/.github/workflows/build-mac.yml +++ b/.github/workflows/build-mac.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "**/*.md" + - "README.md" pull_request: paths-ignore: - - "**/*.md" + - "README.md" jobs: build: diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 56646af069..a0c871f268 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "**/*.md" + - "README.md" pull_request: paths-ignore: - - "**/*.md" + - "README.md" jobs: build: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 11b9faf73d..345e2a8ae8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "**/*.md" + - "README.md" pull_request: paths-ignore: - - "**/*.md" + - "README.md" jobs: build: diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 3718977a8a..7f90cbe4c6 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "**/*.md" + - "README.md" pull_request: paths-ignore: - - "**/*.md" + - "README.md" jobs: build: From 7dce66b0b58da0dd2f25302c869bf54f4d31818f Mon Sep 17 00:00:00 2001 From: Helias Date: Fri, 17 Mar 2023 15:03:18 +0100 Subject: [PATCH 4/5] Revert "ci: ignore README.md" This reverts commit abf7f98e9c1f5650db9f69b51da3e1c3e42099cb. --- .github/workflows/build-linux.yml | 4 ++-- .github/workflows/build-mac.yml | 4 ++-- .github/workflows/build-windows.yml | 4 ++-- .github/workflows/main.yml | 4 ++-- .github/workflows/windows.yml | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 522460bcfa..a4013a18e8 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "README.md" + - "**/*.md" pull_request: paths-ignore: - - "README.md" + - "**/*.md" jobs: build: diff --git a/.github/workflows/build-mac.yml b/.github/workflows/build-mac.yml index bfdf851a26..0926b15ea4 100644 --- a/.github/workflows/build-mac.yml +++ b/.github/workflows/build-mac.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "README.md" + - "**/*.md" pull_request: paths-ignore: - - "README.md" + - "**/*.md" jobs: build: diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index a0c871f268..56646af069 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "README.md" + - "**/*.md" pull_request: paths-ignore: - - "README.md" + - "**/*.md" jobs: build: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 345e2a8ae8..11b9faf73d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "README.md" + - "**/*.md" pull_request: paths-ignore: - - "README.md" + - "**/*.md" jobs: build: diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 7f90cbe4c6..3718977a8a 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -4,10 +4,10 @@ on: branches: - 'master' paths-ignore: - - "README.md" + - "**/*.md" pull_request: paths-ignore: - - "README.md" + - "**/*.md" jobs: build: From b44f2aa7f3780d20e0d8b7630c450148b69f3589 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefano=20Borz=C3=AC?= Date: Fri, 17 Mar 2023 15:22:25 +0100 Subject: [PATCH 5/5] Update README.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Francesco Borzì --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 13b6f2b925..139b3f9fa9 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ Please follow [Angular-cli documentation](https://github.com/angular/angular-cli npm install -g @angular/cli ``` -Only for **Windows** ([Windows 7 or older versions](https://github.com/azerothcore/Keira3/issues/2212) are not officially supported), install windows-build-tools as administrator: +Only for **Windows** ([Windows 7 or older versions](https://github.com/azerothcore/Keira3/issues/2212) are not officially supported), install `windows-build-tools` as administrator: ``` npm install --global-production windows-build-tools ```